Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flags for the Tezos baking app #161

Conversation

spalmer25
Copy link
Contributor

@spalmer25 spalmer25 commented Feb 22, 2024

  • Remove LIBRARY flag as the app is not called as a library
  • Set BOLOS_SETTINGS flag as the app needs lock screen settings
  • Set GLOBAL_PIN flag as the app needs pin validation

@spalmer25 spalmer25 changed the title Update flag for the tezos baking app Update flags for the Tezos baking app Feb 22, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@tezos@baking-app-params-update branch from 1e463cd to 6c6d6a7 Compare February 23, 2024 09:52
@spalmer25 spalmer25 marked this pull request as draft February 23, 2024 09:56
@spalmer25 spalmer25 force-pushed the palmer@functori@tezos@baking-app-params-update branch from 6c6d6a7 to fb23b10 Compare February 23, 2024 10:02
@spalmer25 spalmer25 marked this pull request as ready for review February 23, 2024 10:16
@spalmer25 spalmer25 marked this pull request as draft February 23, 2024 10:21
@spalmer25 spalmer25 marked this pull request as ready for review February 23, 2024 12:14
Copy link
Contributor

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

 - Remove LIBRARY        flag as the app is not called as a library
 - Set    BOLOS_SETTINGS flag as the app needs lock screen settings
 - Set    GLOBAL_PIN     flag as the app needs pin validation
@spalmer25 spalmer25 force-pushed the palmer@functori@tezos@baking-app-params-update branch from 7476022 to 0f4b5a3 Compare February 29, 2024 11:58
@ajinkyaraj-23
Copy link
Contributor

Can we get this merged please @xchapron-ledger ?

@tdejoigny-ledger tdejoigny-ledger merged commit dac0cde into LedgerHQ:main Mar 18, 2024
2 checks passed
@spalmer25 spalmer25 deleted the palmer@functori@tezos@baking-app-params-update branch July 11, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants