Add KLS to database #265
Merged
Add KLS to database #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lemois-1337 ty for you PR |
|
@tdejoigny-ledger Added next-gen Ledger Flex device, was forgotten in first commit, force pushed. |
|
sorry @lemois-1337 my bad, I missed that you have also nanoS. NanoS shall be removed. |
lemois-1337
added a commit
to karlsen-network/app-karlsen
that referenced
this pull request
Oct 8, 2024
Updated supported devices list as mentioned in comment: LedgerHQ/ledger-app-database#265 (comment) Nano S is EOL while Flex is the next-gen Ledger device.
|
@tdejoigny-ledger I've removed NanoS from this PR (force-pushed). I've fixed it in ledger_app.toml as well and thanks for letting me know. |
tdejoigny-ledger
approved these changes
Oct 8, 2024
|
perfect ty @lemois-1337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project: Karlsen
App repository: https://github.com/karlsen-network/app-karlsen
Coin type: 121337 as registered in https://github.com/satoshilabs/slips/blob/master/slip-0044.md