Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is about adding support for the new Liquid Network application in two variants: "liquid" and "liquid_regtest".
Please pay attention to the
"path_slip21"
field that I have defined as:"path_slip21": ["LEDGER-Wallet policy", "SLIP-0077"]
As I understand, using an array here would be non-standard, since all other apps define at most a single path. But I don't have a better idea, as the application really needs two SLIP-0021 paths for normal operation. The first one,
"LEDGER-Wallet policy"
is used to register non-standard wallets in the exactly same way as Bitcoin app does. The Liquid app is based on it and inherits this mechanism as is. Another path,"SLIP-0077"
is used to derive the master blinding key from the seed.Another potential issue is with the
"path"
field. Currently, it is defined in the same way as for the Bitcoin app:"path": [null]
This is definitely not the best way from the side of potential security risks, as it grants the app the right to derive any possible key from the seed. I'd prefer to specify a more restricted list of paths, like:
"path": ["44'/1'", "48'/1'", "49'/1'", "84'/1'", "86'/1'"]
However, with the current SDK, AFAIK, there is no dedicated function returning master key fingerprint. So, like in Bitcoin app, it is computed on the app side, requiring to derive the root pubkey.