fix: remove filters test

LedgerHQ · Jul 15, 2024 · 1a3759b · 1a3759b
1 parent b8daecb
commit 1a3759b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 82 deletions.
diff --git a/apps/ledger-live-desktop/tests/page/swap.page.ts b/apps/ledger-live-desktop/tests/page/swap.page.ts
@@ -1,5 +1,5 @@
-import { waitFor } from "../utils/waitFor";
 import { AppPage } from "tests/page/abstractClasses";
+import { waitFor } from "../utils/waitFor";
 
 export class SwapPage extends AppPage {
   private swapMenuButton = this.page.getByTestId("drawer-swap-button"); // TODO: Should this be here?
@@ -112,22 +112,6 @@ export class SwapPage extends AppPage {
     await this.customFeeTextbox.fill(amount);
   }
 
-  async filterByCentralisedQuotes() {
-    await this.centralisedQuoteFilterButton.click();
-  }
-
-  async filterByDecentralisedQuotes() {
-    await this.decentralisedQuoteFilterButton.click();
-  }
-
-  async filterByFloatingRateQuotes() {
-    await this.floatQuoteFilterButton.click();
-  }
-
-  async filterByFixedRateQuotes() {
-    await this.fixedQuoteFilterButton.click();
-  }
-
   async selectExchangeQuote(
     providerName: "changelly" | "cic" | "oneinch" | "paraswap",
     exchangeType: "fixed" | "float",
@@ -157,11 +141,6 @@ export class SwapPage extends AppPage {
     return this.detailsSwapId.innerText();
   }
 
-  async waitForProviderRates() {
-    await this.centralisedQuoteFilterButton.waitFor({ state: "visible" });
-    await this.decentralisedQuoteFilterButton.waitFor({ state: "visible" });
-  }
-
   // TODO: pull this function out into a utility function so we can use it elsewhere
   async verifyHistoricalSwapsHaveLoadedFully() {
     await this.page.waitForFunction(async () => {

diff --git a/apps/ledger-live-desktop/tests/specs/services/swap.spec.ts b/apps/ledger-live-desktop/tests/specs/services/swap.spec.ts
@@ -1,17 +1,16 @@
 /* eslint-disable @typescript-eslint/no-unused-vars */
-import test from "../../fixtures/mockFixtures";
 import { expect } from "@playwright/test";
-import { SwapPage } from "../../page/swap.page";
-import { DeviceAction } from "../../models/DeviceAction";
-import { Drawer } from "../../page/drawer/drawer";
-import { AccountsPage } from "../../page/accounts.page";
-import { AccountPage } from "../../page/account.page";
 import { Layout } from "../../component/layout.component";
 import { Modal } from "../../component/modal.component";
+import test from "../../fixtures/mockFixtures";
+import { DeviceAction } from "../../models/DeviceAction";
+import { AccountPage } from "../../page/account.page";
+import { AccountsPage } from "../../page/accounts.page";
+import { Drawer } from "../../page/drawer/drawer";
+import { SwapPage } from "../../page/swap.page";
 import {
   getBitcoinToDogecoinRatesMock,
   getBitcoinToEthereumRatesMock,
-  getEthereumToTetherRatesMock,
   getProvidersCDNDataMock,
 } from "./services-api-mocks/getRates.mock";
 
@@ -97,7 +96,6 @@ test.describe.parallel("Swap", () => {
       await swapPage.selectCurrencyFromCurrencyDropdown("Dogecoin");
       await swapPage.sendMax(); // entering amount in textbox doesn't generate a quote in mock/PW
       await layout.waitForLoadingSpinnerToHaveDisappeared();
-      await swapPage.waitForProviderRates();
       await expect.soft(page).toHaveScreenshot("add-to-account-button.png");
     });
 
@@ -107,58 +105,6 @@ test.describe.parallel("Swap", () => {
     });
   });
 
-  test("Filter Rates @smoke", async ({ page, mockProviderSvgs, mockFeesEndpoint }) => {
-    const swapPage = new SwapPage(page);
-    const layout = new Layout(page);
-
-    await page.route("https://swap.ledger.com/v5/rate**", async route => {
-      const mockRatesResponse = getEthereumToTetherRatesMock();
-      await route.fulfill({ headers: { teststatus: "mocked" }, body: mockRatesResponse });
-    });
-
-    await page.route("https://cdn.live.ledger.com/swap-providers/data.json", async route => {
-      const mockProvidersResponse = getProvidersCDNDataMock();
-      await route.fulfill({ headers: { teststatus: "mocked" }, body: mockProvidersResponse });
-    });
-
-    await test.step("Generate ETH to USDT quotes", async () => {
-      await swapPage.navigate();
-      await swapPage.reverseSwapPair();
-      await swapPage.filterDestinationCurrencyDropdown("Tether USD");
-      await layout.waitForLoadingSpinnerToHaveDisappeared();
-      await swapPage.selectCurrencyFromCurrencyDropdown("Tether USD");
-      await swapPage.sendMax();
-      await layout.waitForLoadingSpinnerToHaveDisappeared();
-      await swapPage.waitForProviderRates();
-      await expect.soft(page).toHaveScreenshot("eth-to-usdt-quotes-generated.png");
-    });
-
-    await test.step("Decentralised Quotes filtered", async () => {
-      await swapPage.filterByDecentralisedQuotes();
-      await expect.soft(page).toHaveScreenshot("only-decentralised-quotes-displayed.png");
-    });
-
-    await test.step("Fixed Decentralised Quotes filtered", async () => {
-      await swapPage.filterByFixedRateQuotes();
-      await expect.soft(page).toHaveScreenshot("fixed-decentralised-quotes-displayed.png");
-    });
-
-    await test.step("Floating Decentralised Quotes filtered", async () => {
-      await swapPage.filterByFloatingRateQuotes();
-      await expect.soft(page).toHaveScreenshot("floating-decentralised-quotes-displayed.png");
-    });
-
-    await test.step("Floating Centralised Quotes filtered", async () => {
-      await swapPage.filterByCentralisedQuotes();
-      await expect.soft(page).toHaveScreenshot("floating-centralised-quotes-displayed.png");
-    });
-
-    await test.step("Fixed Centralised filtered", async () => {
-      await swapPage.filterByFixedRateQuotes();
-      await expect.soft(page).toHaveScreenshot("fixed-centralised-quotes-diplayed.png");
-    });
-  });
-
   test("Full Swap with Centralised Exchange @smoke", async ({
     page,
     mockProviderSvgs,