Skip to content

Commit

Permalink
🐛(lld): fix inte test for nfts (#7914)
Browse files Browse the repository at this point in the history
  • Loading branch information
LucasWerey authored Sep 26, 2024
1 parent 1f583cc commit d3fa14f
Show file tree
Hide file tree
Showing 4 changed files with 31 additions and 15 deletions.
5 changes: 5 additions & 0 deletions .changeset/fresh-cobras-argue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"ledger-live-desktop": patch
---

Fix unstable integration test
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ describe("displayNftCollection", () => {
});

await waitFor(() => expect(screen.getByText(/momentum/i)).toBeVisible());
await expect(screen.getByText(/receive nft/i)).toBeVisible();
await expect(screen.getByText(/see gallery/i)).toBeVisible();
await expect(screen.getByText(/see more collections/i)).toBeVisible();
expect(screen.getByText(/receive nft/i)).toBeVisible();
expect(screen.getByText(/see gallery/i)).toBeVisible();
expect(screen.getByText(/see more collections/i)).toBeVisible();
});

it("should open the NFTs gallery", async () => {
Expand All @@ -36,10 +36,10 @@ describe("displayNftCollection", () => {
});

await waitFor(() => expect(screen.getByText(/momentum/i)).toBeVisible());
await expect(screen.getByText(/receive nft/i)).toBeVisible();
await expect(screen.getByText(/see gallery/i)).toBeVisible();
expect(screen.getByText(/receive nft/i)).toBeVisible();
expect(screen.getByText(/see gallery/i)).toBeVisible();
await user.click(screen.getByText(/see gallery/i));
await expect(screen.getByText(/all nft/i)).toBeVisible();
expect(screen.getByText(/all nft/i)).toBeVisible();
});

it("should open the corresponding NFTs collection and the correct detail drawer", async () => {
Expand All @@ -65,10 +65,10 @@ describe("displayNftCollection", () => {

// Open external viewer
await user.click(screen.getByTestId("external-viewer-button"));
await expect(screen.getByText(/open in opensea.io/i)).toBeVisible();
expect(screen.getByText(/open in opensea.io/i)).toBeVisible();

// Close drawer
await waitFor(() => user.click(screen.getByTestId("drawer-close-button")));
await user.click(screen.getByTestId("drawer-close-button"));
await waitFor(() => expect(screen.queryByTestId("side-drawer-container")).toBeNull());
});

Expand All @@ -80,7 +80,7 @@ describe("displayNftCollection", () => {
initialRoute: `/`,
});

await expect(screen.getByText(/receive nft/i)).toBeVisible();
await expect(screen.getByText(/learn more/i)).toBeVisible();
expect(screen.getByText(/receive nft/i)).toBeVisible();
expect(screen.getByText(/learn more/i)).toBeVisible();
});
});
5 changes: 5 additions & 0 deletions apps/ledger-live-desktop/tests/handlers/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
import NFTsHandlers from "./nfts";

export default [...NFTsHandlers];

export const ALLOWED_UNHANDLED_REQUESTS = [
"https://nft.api.live.ledger.com/v1/marketdata/ethereum/1/contract/0xe3BE0054Da2F8da5002E8bdD8AA4c7fDf851E86D/floor-price",
"https://nft.api.live.ledger.com/v1/ethereum/1/contracts/infos",
];
16 changes: 11 additions & 5 deletions apps/ledger-live-desktop/tests/jestSetup.js
Original file line number Diff line number Diff line change
@@ -1,17 +1,23 @@
import "@jest/globals";
import "@testing-library/jest-dom";
import { server } from "./server";
import { ALLOWED_UNHANDLED_REQUESTS } from "./handlers";

global.setImmediate = global.setImmediate || ((fn, ...args) => global.setTimeout(fn, 0, ...args));

beforeAll(() => server.listen());
beforeAll(() =>
server.listen({
onUnhandledRequest(request, print) {
if (ALLOWED_UNHANDLED_REQUESTS.some(ignoredUrl => request.url.includes(ignoredUrl))) {
return;
}
print.warning();
},
}),
);
afterEach(() => server.resetHandlers());
afterAll(() => server.close());

server.events.on("request:start", ({ request }) => {
console.log("MSW intercepted:", request.method, request.url);
});

jest.mock("src/sentry/install", () => ({
init: jest.fn(),
setUser: jest.fn(),
Expand Down

0 comments on commit d3fa14f

Please sign in to comment.