fix(lld): define optOut as disabled share personalized recommendations

LedgerHQ · Feb 13, 2025 · e2228e8 · e2228e8
1 parent 8e3ff77
commit e2228e8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/apps/ledger-live-desktop/src/newArch/features/LNSUpsell/__tests__/LNSBannerCard.test.tsx b/apps/ledger-live-desktop/src/newArch/features/LNSUpsell/__tests__/LNSBannerCard.test.tsx
@@ -87,7 +87,8 @@ describe("LNSBannerCard", () => {
       render(<LNSBannerCard location={location} fallback={<div data-testid="fallback" />} />, {
         initialState: {
           settings: {
-            shareAnalytics: isOptIn,
+            shareAnalytics: true,
+            sharePersonalizedRecommandations: isOptIn,
             overriddenFeatureFlags: {
               lldNanoSUpsellBanners: { enabled: ffEnabled, params: ffParams },
             },

diff --git a/...dger-live-desktop/src/newArch/features/LNSUpsell/__tests__/LNSNotificationBanner.test.tsx b/...dger-live-desktop/src/newArch/features/LNSUpsell/__tests__/LNSNotificationBanner.test.tsx
@@ -65,7 +65,8 @@ describe("LNSNotificationBanner", () => {
     render(<LNSNotificationBanner />, {
       initialState: {
         settings: {
-          shareAnalytics: isOptIn,
+          shareAnalytics: true,
+          sharePersonalizedRecommandations: isOptIn,
           overriddenFeatureFlags: {
             lldNanoSUpsellBanners: { enabled: ffEnabled, params: ffParams },
           },

diff --git a/apps/ledger-live-desktop/src/newArch/features/LNSUpsell/hooks/useLNSBanner.ts b/apps/ledger-live-desktop/src/newArch/features/LNSUpsell/hooks/useLNSBanner.ts
@@ -2,11 +2,11 @@ import { useSelector } from "react-redux";
 import { useFeature } from "@ledgerhq/live-common/featureFlags/index";
 import { track } from "~/renderer/analytics/segment";
 import { openURL } from "~/renderer/linking";
-import { trackingEnabledSelector } from "~/renderer/reducers/settings";
+import { sharePersonalizedRecommendationsSelector } from "~/renderer/reducers/settings";
 import { AnalyticsButton, AnalyticsPage, type LNSBannerLocation } from "../types";
 
 export function useLNSBanner(location: LNSBannerLocation) {
-  const isOptIn = useSelector(trackingEnabledSelector);
+  const isOptIn = useSelector(sharePersonalizedRecommendationsSelector);
   const ff = useFeature("lldNanoSUpsellBanners");
   const params = ff?.params?.[isOptIn ? "opted_in" : "opted_out"];