Support/fix casper history

.changeset/large-needles-watch.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/live-common": patch
+---
+
+Fix sometimes missing ops for accounts on casper

libs/ledger-live-common/src/families/casper/api/types.ts

@@ -42,9 +42,11 @@ export interface ITxnHistoryData {
     };
     target: {
       parsed: string;
-      cl_type: {
-        ByteArray: number;
-      };
+      cl_type:
+        | {
+            ByteArray: number;
+          }
+        | string;
     };
   };
   amount: string;

libs/ledger-live-common/src/families/casper/bridge/bridgeHelpers/txn.ts

@@ -10,6 +10,7 @@ import { casperAccountHashFromPublicKey, casperGetCLPublicKey, isAddressValid }
 import { ITxnHistoryData } from "../../api/types";
 import { getEstimatedFees } from "./fee";
 import { CasperOperation } from "../../types";
+import invariant from "invariant";
 
 export const getUnit = (): Unit => getCryptoCurrencyById("casper").units[0];
 
@@ -19,59 +20,72 @@ export function mapTxToOps(
   fees = getEstimatedFees(),
 ): (tx: ITxnHistoryData) => CasperOperation[] {
   return (tx: ITxnHistoryData): CasperOperation[] => {
-    const ops: CasperOperation[] = [];
-    const { timestamp, caller_public_key, args: txArgs, deploy_hash, error_message } = tx;
-    const fromAccount = casperAccountHashFromPublicKey(caller_public_key);
-    const toAccount = txArgs.target.parsed;
+    try {
+      const ops: CasperOperation[] = [];
+      const { timestamp, caller_public_key, args: txArgs, deploy_hash, error_message } = tx;
+      const fromAccount = casperAccountHashFromPublicKey(caller_public_key);
+      let toAccount;
 
-    const date = new Date(timestamp);
-    const value = new BigNumber(txArgs.amount.parsed);
-    const feeToUse = fees;
+      if (txArgs.target.cl_type === "PublicKey") {
+        toAccount = casperAccountHashFromPublicKey(txArgs.target.parsed);
+      } else {
+        toAccount = txArgs.target.parsed;
+      }
+      invariant(toAccount, "toAccount is required");
+      invariant(fromAccount, "fromAccount is required");
 
-    const isSending = addressHash.toLowerCase() === fromAccount.toLowerCase();
-    const isReceiving = addressHash.toLowerCase() === toAccount.toLowerCase();
+      const date = new Date(timestamp);
+      const value = new BigNumber(txArgs.amount.parsed);
+      const feeToUse = fees;
 
-    if (isSending) {
-      ops.push({
-        id: encodeOperationId(accountId, deploy_hash, "OUT"),
-        hash: deploy_hash,
-        type: "OUT",
-        value: value.plus(feeToUse),
-        fee: feeToUse,
-        blockHeight: 1,
-        hasFailed: error_message ? true : false,
-        blockHash: null,
-        accountId,
-        senders: [fromAccount],
-        recipients: [toAccount],
-        date,
-        extra: {
-          transferId: txArgs.id.parsed?.toString(),
-        },
-      });
-    }
+      const isSending = addressHash.toLowerCase() === fromAccount.toLowerCase();
+      const isReceiving = addressHash.toLowerCase() === toAccount.toLowerCase();
 
-    if (isReceiving) {
-      ops.push({
-        id: encodeOperationId(accountId, deploy_hash, "IN"),
-        hash: deploy_hash,
-        type: "IN",
-        value,
-        fee: feeToUse,
-        blockHeight: 1,
-        blockHash: null,
-        hasFailed: error_message ? true : false,
-        accountId,
-        senders: [fromAccount],
-        recipients: [toAccount],
-        date,
-        extra: {
-          transferId: txArgs.id.parsed?.toString(),
-        },
-      });
-    }
+      if (isSending) {
+        ops.push({
+          id: encodeOperationId(accountId, deploy_hash, "OUT"),
+          hash: deploy_hash,
+          type: "OUT",
+          value: value.plus(feeToUse),
+          fee: feeToUse,
+          blockHeight: 1,
+          hasFailed: error_message ? true : false,
+          blockHash: null,
+          accountId,
+          senders: [fromAccount],
+          recipients: [toAccount],
+          date,
+          extra: {
+            transferId: txArgs.id.parsed?.toString(),
+          },
+        });
+      }
 
-    return ops;
+      if (isReceiving) {
+        ops.push({
+          id: encodeOperationId(accountId, deploy_hash, "IN"),
+          hash: deploy_hash,
+          type: "IN",
+          value,
+          fee: feeToUse,
+          blockHeight: 1,
+          blockHash: null,
+          hasFailed: error_message ? true : false,
+          accountId,
+          senders: [fromAccount],
+          recipients: [toAccount],
+          date,
+          extra: {
+            transferId: txArgs.id.parsed?.toString(),
+          },
+        });
+      }
+
+      return ops;
+    } catch (err) {
+      log("warn", `mapTxToOps failed for casper, skipping operation`, err);
+      return [];
+    }
   };
 }