Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ›fix(crypto-icons): change size of polkadot icon #7442

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jul 26, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Polkadot icon

πŸ“ Description

Polkadot icon was bigger than the others. Change the size inside the svg
To see the change you need to pnpm clean && pnpm store prune and pnpm i && pnpm build:lld:deps && pnpm build:llm:deps

image

Video :
https://github.com/user-attachments/assets/9290554e-3d0f-427d-8a95-346cee955195

Before After
image image

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner July 26, 2024 15:55
Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 26, 2024 3:56pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Jul 26, 2024 3:56pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Jul 26, 2024 3:56pm
native-ui-storybook ⬜️ Ignored (Inspect) Jul 26, 2024 3:56pm
react-ui-storybook ⬜️ Ignored (Inspect) Jul 26, 2024 3:56pm

@LucasWerey LucasWerey merged commit 3415d7d into develop Jul 26, 2024
37 of 49 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-11722 branch July 26, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants