Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ›fix(lld): ws manage instances scroll #7557

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Aug 8, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

When there is many instances / reduced app screen we couldn't scroll to the last card.

Screen.Recording.2024-08-08.at.15.05.57.mov

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner August 8, 2024 13:09
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Aug 8, 2024 1:09pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Aug 8, 2024 1:09pm
native-ui-storybook ⬜️ Ignored (Inspect) Aug 8, 2024 1:09pm
react-ui-storybook ⬜️ Ignored (Inspect) Aug 8, 2024 1:09pm
web-tools ⬜️ Ignored (Inspect) Aug 8, 2024 1:09pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Aug 8, 2024
@LucasWerey LucasWerey merged commit 760ce85 into develop Aug 8, 2024
34 of 37 checks passed
@LucasWerey LucasWerey deleted the fix/ws_manage_scroll branch August 8, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants