Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #7793 from LedgerHQ/hotfix/swap-button #7794

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

CremaFR
Copy link
Member

@CremaFR CremaFR commented Sep 11, 2024

hotfix: swap button fix

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@CremaFR CremaFR requested a review from a team as a code owner September 11, 2024 12:38
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 0:38am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 0:38am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 0:38am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 0:38am
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 11, 2024 0:38am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 11, 2024
@CremaFR CremaFR merged commit 4128cce into develop Sep 11, 2024
30 checks passed
@CremaFR CremaFR deleted the cherrypick/release branch September 11, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants