[Playwright] speculos // swap e2e tests with common currencies (BTC, USDT, ETH)

.github/pull_request_template.md

@@ -8,15 +8,15 @@ Please make sure to read CONTRIBUTING.md if you have not already. Pull Requests
 <!-- Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready. -->
 
 - [ ] `npx changeset` was attached.
-- [ ] **Covered by automatic tests.** <!-- if not, please explain. (Feature must be tested / Bugfix must bring non-regression) -->
+- [ ] **Covered by automatic tests.** <!-- if not, please explain. (Feature must be tested / Bug fix must bring non-regression) -->
 - [ ] **Impact of the changes:** <!-- Please take some time to list the impact & what specific areas Quality Assurance (QA) should focus on -->
   - ...
 
 ### 📝 Description
 
 _Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing._
 _For libraries, you can add a code sample of how to use it._
-_For bugfixes, you can explain the previous behavior and how it was fixed._
+_For bug fixes, you can explain the previous behaviour and how it was fixed._
 _In case of visual features, please attach screenshots or video recordings to demonstrate the changes._
 
 <!--

apps/ledger-live-desktop/tests/enum/Account.ts

@@ -1,10 +1,12 @@
 import { Currency } from "./Currency";
+import { AccountType } from "tests/enum/AccountType";
 
 export class Account {
   constructor(
     public readonly currency: Currency,
     public readonly accountName: string,
     public readonly address: string,
+    public readonly accountType?: AccountType,
   ) {}
 
   static readonly BTC_NATIVE_SEGWIT_1 = new Account(
@@ -257,12 +259,14 @@ export class Account {
     Currency.ETH_USDT,
     "Ethereum 1",
     "0xB9051f83AC6e147924377BBEebd1Aa7aB43a67F6",
+    AccountType.ERC20,
   );
 
   static readonly ETH_USDT_2 = new Account(
     Currency.ETH_USDT,
     "Ethereum 2",
     "0x43047a5023D55a8658Fcb1c1Cea468311AdAA3Ad",
+    AccountType.ERC20,
   );
 
   static readonly ETH_LIDO = new Account(
@@ -299,6 +303,7 @@ export class Account {
     Currency.TRX_USDT,
     "Tron 1",
     "TDUKFB9wj3P5f2iNvkRuaDDeWVkTdUVhs1",
+    AccountType.TRC20,
   );
 
   static readonly TRX_BTT = new Account(

apps/ledger-live-desktop/tests/enum/AccountType.ts

@@ -0,0 +1,4 @@
+export enum AccountType {
+  ERC20 = "erc20",
+  TRC20 = "trc20",
+}

apps/ledger-live-desktop/tests/enum/Swap.ts

@@ -1,5 +1,10 @@
-export enum Providers {
-  CHANGELLY = "changelly",
+export class Provider {
+  constructor(
+    public readonly name: string,
+    public readonly uiName: string,
+  ) {}
+  static readonly CHANGELLY = new Provider("changelly", "Changelly");
+  static readonly ONEINCH = new Provider("oneinch", "1inch");
 }
 
 export enum Rates {

apps/ledger-live-desktop/tests/models/Swap.ts

@@ -1,17 +1,22 @@
 import { Transaction } from "tests/models/Transaction";
 import { Fee } from "tests/enum/Fee";
 import { Account } from "../enum/Account";
+import { Provider } from "../enum/Swap";
 
 export class Swap extends Transaction {
+  provider: Provider;
+
   constructor(
     accountToDebit: Account,
     accountToCredit: Account,
     amount: string,
     speed: Fee,
+    provider: Provider,
     public amountToReceive?: string,
     public feesAmount?: string,
   ) {
     super(accountToDebit, accountToCredit, amount, speed);
+    this.provider = provider;
   }
 
   public setAmountToReceive(value: string) {

apps/ledger-live-desktop/tests/page/abstractClasses.ts

@@ -25,6 +25,10 @@ export abstract class Component extends PageHolder {
   async waitForPageLoadState() {
     return await this.page.waitForLoadState("load");
   }
+
+  async waitForPageNetworkidleState() {
+    return await this.page.waitForLoadState("networkidle");
+  }
 }
 
 export abstract class AppPage extends Component {}

apps/ledger-live-desktop/tests/page/speculos.page.ts

@@ -74,16 +74,8 @@ export class SpeculosPage extends AppPage {
       verifyAmount(`${swap.accountToDebit.currency.ticker} ${swap.amount}`, sendAmountScreen),
     ).toBeTruthy();
     const getAmountScreen = await pressRightUntil(sendPattern[1]);
-    expect(
-      verifyAmount(
-        `${swap.accountToCredit.currency.ticker} ${extractNumberFromString(swap.amountToReceive)}`,
-        getAmountScreen,
-      ),
-    ).toBeTruthy();
-    const feesAmountScreen = await pressRightUntil(sendPattern[2]);
-    expect(
-      verifySwapFeesAmount(extractNumberFromString(swap.feesAmount), feesAmountScreen),
-    ).toBeTruthy();
+    this.verifySwapGetAmountScreen(swap, getAmountScreen);
+    this.verifySwapFeesAmountScreen(swap, await pressRightUntil(sendPattern[2]));
     await pressRightUntil(DeviceLabels.REJECT);
     await pressBoth();
   }
@@ -145,4 +137,36 @@ export class SpeculosPage extends AppPage {
         throw new Error(`Unsupported currency: ${currencyName}`);
     }
   }
+
+  verifySwapGetAmountScreen(swap: Swap, getAmountScreen: string[]) {
+    if (swap.accountToCredit.currency.name === "Solana") {
+      expect(
+        verifyAmount(
+          `${extractNumberFromString(swap.amountToReceive)} ${swap.accountToCredit.currency.ticker}`,
+          getAmountScreen,
+        ),
+      ).toBeTruthy();
+    } else {
+      expect(
+        verifyAmount(
+          `${swap.accountToCredit.currency.ticker} ${extractNumberFromString(swap.amountToReceive)}`,
+          getAmountScreen,
+        ),
+      ).toBeTruthy();
+    }
+  }
+
+  verifySwapFeesAmountScreen(swap: Swap, feesAmountScreen: string[]) {
+    let speculosFeesAmount = "";
+    if (swap.feesAmount) {
+      //max number of chars on the screen
+      speculosFeesAmount =
+        extractNumberFromString(swap.feesAmount).length < 18
+          ? extractNumberFromString(swap.feesAmount)
+          : extractNumberFromString(swap.feesAmount).substring(0, 17);
+    }
+    expect(
+      verifySwapFeesAmount(swap.accountToDebit.currency.name, speculosFeesAmount, feesAmountScreen),
+    ).toBeTruthy();
+  }
 }

apps/ledger-live-desktop/tests/page/swap.page.ts

@@ -3,6 +3,7 @@ import { waitFor } from "../utils/waitFor";
 import { step } from "tests/misc/reporters/step";
 import { ElectronApplication, expect } from "@playwright/test";
 import { capitalizeFirstLetter } from "tests/utils/textParserUtils";
+import { Account } from "tests/enum/Account";
 
 export class SwapPage extends AppPage {
   private currencyByName = (accountName: string) => this.page.getByText(accountName); // TODO: this is rubbish. Changed this
@@ -115,10 +116,7 @@ export class SwapPage extends AppPage {
   }
 
   @step("Select exchange quote $0 with rate $1")
-  async selectExchangeQuote(
-    providerName: "changelly" | "cic" | "oneinch" | "paraswap",
-    exchangeType: "fixed" | "float",
-  ) {
+  async selectExchangeQuote(providerName: string, exchangeType: "fixed" | "float") {
     await this.quoteContainer(providerName, exchangeType).click();
   }
 
@@ -150,13 +148,25 @@ export class SwapPage extends AppPage {
     return this.detailsSwapId.innerText();
   }
 
-  @step("Select account to swap from: $0")
-  async selectAccountToSwapFrom(accountToSwapFrom: string) {
+  getAccountName(account: Account) {
+    //erc20 accounts names are stored in account currency property
+    return account.accountType ? account.currency.name : account.accountName;
+  }
+
+  @step("Select account to swap from")
+  async selectAccountToSwapFrom(accountToSwapFrom: Account) {
     await this.originCurrencyDropdown.click();
-    await this.dropdownOptions.locator(this.optionWithText(accountToSwapFrom)).click();
+    const accName = this.getAccountName(accountToSwapFrom);
+    if (accountToSwapFrom.accountType) {
+      await this.dropdownOptions
+        .locator(this.optionWithTextAndFollowingText(accountToSwapFrom.accountName, accName))
+        .first()
+        .click();
+    } else {
+      await this.dropdownOptions.locator(this.optionWithText(accName)).first().click();
+    }
     const selectedAccountFrom = this.originCurrencyDropdown.locator(this.dropdownSelectedValue);
-    await expect(selectedAccountFrom).toHaveText(accountToSwapFrom);
-    await this.waitForPageLoadState();
+    await expect(selectedAccountFrom).toHaveText(accName);
   }
 
   @step("Fill in amount: $0")

apps/ledger-live-desktop/tests/playwright.config.ts

@@ -6,17 +6,18 @@ const config: PlaywrightTestConfig = {
       name: "speculos_tests",
       testDir: "specs/speculos/",
       retries: process.env.CI ? 2 : 0,
+      timeout: process.env.CI ? 400000 : 1200000,
     },
     {
       name: "mocked_tests",
       testDir: "specs/",
       testIgnore: ["**/speculos/**", "specs/recorder.spec.ts"],
+      timeout: process.env.CI ? 190000 : 600000,
     },
   ],
   outputDir: "./artifacts/test-results",
   snapshotPathTemplate:
     "{snapshotDir}/{testFileDir}/{testFileName}-snapshots/{arg}{-platform}{ext}",
-  timeout: process.env.CI ? 190000 : 600000,
   expect: {
     timeout: 41000,
     toHaveScreenshot: {