feat: init ldmk-transport pkg #8092
Open
+362
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
jdabbech-ledger
previously requested changes
Oct 14, 2024
libs/ldmk-transport/package.json
Outdated
| @@ -0,0 +1,56 @@ | |||
| { | |||
| "name": "@ledgerhq/ldmk-transport", | |||
There was a problem hiding this comment.
shouldn't it be named @ledgerhq/live-dmdk ?
There was a problem hiding this comment.
indeed the package should be called @ledgerhq/live-dmk
libs/ldmk-transport/src/index.tsx
Outdated
| ).catch(e => console.error("[SDKTransport][open] error getting device session state", e)); | ||
|
|
||
| if (deviceSessionState?.deviceStatus !== DeviceStatus.NOT_CONNECTED) { | ||
| console.log( |
There was a problem hiding this comment.
[could] use LocalTracer logs
fAnselmi-Ledger
force-pushed
the
DSDK-506-ts-dmk-ll-create-package-live-dmk-inside-ledger-live-repo
branch
from
f6acf9e
to
ce297ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Created LDMK transport package
❓ Context
🧐 Checklist for the PR Reviewers