Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update the nightly app name #8138

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

desirendr
Copy link
Contributor

@desirendr desirendr commented Oct 18, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Quick update on the naming of the nightly app so that it fits the request coming from Guillaume M.

❓ Context

https://ledgerhq.atlassian.net/browse/LIVE-14568


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Quick update on the naming of the nightly app so that it fits the request coming from Guillaume M.
@desirendr desirendr requested a review from a team as a code owner October 18, 2024 09:48
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 18, 2024 9:48am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 18, 2024 9:48am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 18, 2024 9:48am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 18, 2024 9:48am
web-tools ⬜️ Ignored (Inspect) Oct 18, 2024 9:48am

@desirendr desirendr merged commit bd27579 into develop Oct 18, 2024
44 checks passed
@desirendr desirendr deleted the live-14568/update-nightly-app-naming branch October 18, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants