✨(lld): change sync error tooltip to be more readable #8140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
live-github-bot
bot
added
desktop
LucasWerey
force-pushed
the
feat/LIVE-14060
branch
from
b1d44e1
to
36bb5e8
Compare
LucasWerey
force-pushed
the
feat/LIVE-14060
branch
from
36bb5e8
to
d24219e
Compare
themooneer
reviewed
Oct 18, 2024
| accounts?: (Account | null)[]; | ||
| } = {}): AccountWithSyncState[] { | ||
| const syncState = useBridgeSyncState(); | ||
| if (!accounts) return []; |
There was a problem hiding this comment.
you can add || !account?.length too
| accounts: (AccountLike | null | undefined)[], | ||
| ): (string | undefined)[] => { | ||
| return useSelector((state: State) => | ||
| accounts.map(account => |
There was a problem hiding this comment.
Can we put the content of this map in a function to factorize with the useMaybeAccountName function above
| ) : ( | ||
| <Box> | ||
| <Text mb={1} textAlign="left"> | ||
| {"Accounts failing to sync:"} |
There was a problem hiding this comment.
Why is this text not in the translations file ?
LucasWerey
force-pushed
the
feat/LIVE-14060
branch
from
d24219e
to
f917d45
Compare
cgrellard-ledger
approved these changes
Oct 18, 2024
themooneer
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
in purpose to add a more readable UI inside sync tooltips we will display all the accounts that failed to sync (not update to date / not supported ). For this I've added batch hook to find all the account names
Screen.Recording.2024-10-18.at.13.25.08.mov
❓ Context
🧐 Checklist for the PR Reviewers