Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ›(lld): nft breadcrumb not filtering spam #8149

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Oct 18, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • nft breadcrumb newarch and current

πŸ“ Description

The nft breadcrumb (newArch and current) was not filtering the spam nfts. The code is duplicated in both because newArch is under ff and the current will be removed a day

Screen.Recording.2024-10-18.at.17.32.39.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner October 18, 2024 15:38
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 18, 2024 3:39pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 18, 2024 3:39pm
native-ui-storybook ⬜️ Ignored (Inspect) Oct 18, 2024 3:39pm
react-ui-storybook ⬜️ Ignored (Inspect) Oct 18, 2024 3:39pm
web-tools ⬜️ Ignored (Inspect) Oct 18, 2024 3:39pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant