Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA][Detox] Add Speculos screenshots for failed tests #9192

Merged
merged 2 commits into from
Feb 14, 2025
Merged

[QAA][Detox] Add Speculos screenshots for failed tests #9192

merged 2 commits into from
Feb 14, 2025

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Feb 11, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • E2E Allure reporting

📝 Description

Add Speculos screenshots for failed tests

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 10:13pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 10:13pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 10:13pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 10:13pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM common Has changes in live-common labels Feb 11, 2025
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_475_detox_add_speculos_screenshot branch from d3b693a to a53b01f Compare February 11, 2025 16:32
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review February 11, 2025 17:00
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners February 11, 2025 17:00
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_475_detox_add_speculos_screenshot branch from a53b01f to 335d029 Compare February 11, 2025 19:04
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_475_detox_add_speculos_screenshot branch from 335d029 to 852377a Compare February 12, 2025 10:07
@abdurrahman-ledger abdurrahman-ledger added this pull request to the merge queue Feb 14, 2025
Merged via the queue into develop with commit 15db89b Feb 14, 2025
64 of 69 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/qaa_475_detox_add_speculos_screenshot branch February 14, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdurrahman-ledger @cgrellard-ledger @ypolishchuk-ledger