-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: re-introduce SpamFilter for TX (Nfts) #9206
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
3 Skipped Deployments
|
a4ec573
to
2119457
Compare
2119457
to
c691207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to handle batch like useNftMetadataBatch
Maybe it's not the best way to do but I just copied hook above and adapt it for Collection
c691207
to
0061fb0
Compare
)} | ||
{groupedOperations?.sections?.map( | ||
group => | ||
group.data.length > 0 && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to avoid a condition on each and every group, i would use a filtered sections before.
Maybe not on the component level, i think here useOperationsList
when you build the groupedOperations
, make sure the sections in it (if you don't use) don't contain empty data group.
apps/ledger-live-desktop/src/renderer/components/OperationsList/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/OperationsList/useOperationsList.ts
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/OperationsList/useOperationsList.ts
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/OperationsList/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/OperationsList/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/OperationsList/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/OperationsList/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/renderer/components/OperationsList/useOperationsList.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very nice to review PR ! π
1ab8772
to
57452a7
Compare
|
β Checklist
npx changeset
was attached.π Description
How it works :
![Screenshot 2025-02-12 at 15 33 39](https://private-user-images.githubusercontent.com/112866305/412468183-6e1163a7-332f-4374-9c92-567dc1dce084.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MzA3MTksIm5iZiI6MTczOTkzMDQxOSwicGF0aCI6Ii8xMTI4NjYzMDUvNDEyNDY4MTgzLTZlMTE2M2E3LTMzMmYtNDM3NC05YzkyLTU2N2RjMWRjZTA4NC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxOVQwMjAwMTlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05Yjc1ZjcwOGE2NTEzYzVkMDljM2ZlYWVmMDQwZDZhYWNhYmU0M2M2ZDNhMTNmZWNlN2U2YzI1NTRhZjUwYWMwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.jYxavhAcWxB6y2rzDtIsmrTpk77Y06V-M7Tvv1hxJfo)
ποΈ We have a centralised hook in common for reuse in LLM and LLD
NFT_IN
tx onlyβΉοΈ Key points:
π€ N.B: There are several network calls that go out because we need to process each NFT (collection) that we have in the operations
The calls go out as soon as the operations (which are recalculated to filter the operations on the NFTs) are ready, which is why we sometimes see 5-6 requests go out.
Demo :
Screen.Recording.2025-02-12.at.16.04.55.mov
And then added in
hiddenCollections
Screen.Recording.2025-02-12.at.16.19.23.mov
β Context
π§ Checklist for the PR Reviewers