Merge pull request #432 from LedgerHQ/tdj/deprecate_check_api_level_f…

…unction Deprecate "check_api_level" function
LedgerHQ · Sep 22, 2023 · b2ca981 · b2ca981
2 parents 81ff49c + 5a6d52d
commit b2ca981
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/include/os_apilevel.h b/include/os_apilevel.h
@@ -19,7 +19,15 @@
 #ifndef OS_APILEVEL_H
 #define OS_APILEVEL_H
 
+#ifndef HAVE_BOLOS
+// Obsolete defines - shall not be used
+// Replaced by API_LEVEL mechanism enforced directly at app sideloading.
+// Hence the app can consider it runs on a OS which match the SDK the app has been built for.
+#define CX_APILEVEL        _Pragma("GCC warning \"Deprecated constant!\"") 12
+#define CX_COMPAT_APILEVEL _Pragma("GCC warning \"Deprecated constant!\"") 12
+#else
 #define CX_APILEVEL        12
 #define CX_COMPAT_APILEVEL 12
+#endif
 
 #endif  // OS_APILEVEL_H
diff --git a/include/os_id.h b/include/os_id.h
@@ -49,7 +49,10 @@ unsigned int os_get_sn(unsigned char *buffer);
 SYSCALL unsigned int get_api_level(void);
 
 #ifndef HAVE_BOLOS
-static inline void check_api_level(unsigned int apiLevel)
+// Obsolete function - shall not be used
+// Replaced by API_LEVEL mechanism enforced directly at app sideloading.
+// Hence the app can consider it runs on a OS which match the SDK the app has been built for.
+DEPRECATED static inline void check_api_level(unsigned int apiLevel)
 {
     if (apiLevel < get_api_level()) {
         os_sched_exit(-1);

diff --git a/src/os_io_seproxyhal.c b/src/os_io_seproxyhal.c
@@ -417,9 +417,6 @@ static const unsigned char seph_io_mcu_protect[] = {
 void io_seproxyhal_init(void)
 {
 #ifndef HAVE_BOLOS
-    // Enforce OS compatibility
-    check_api_level(CX_COMPAT_APILEVEL);
-
 #ifdef HAVE_MCU_PROTECT
     // engage RDP2 on MCU
     io_seproxyhal_spi_send(seph_io_mcu_protect, sizeof(seph_io_mcu_protect));