Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fbe/load script improvements #372

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

fbeutin-ledger
Copy link
Contributor

Description

Add empty .bss section enforcer in loader scripts for plugin compilation
Add empty .data section enforcer in loader scripts for all targets

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@fbeutin-ledger fbeutin-ledger force-pushed the fbe/load_script_improvements branch 3 times, most recently from a3044b7 to cbfd912 Compare July 11, 2023 12:46
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5f4ab50) 69.09% compared to head (9988903) 69.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #372   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files          11       11           
  Lines         864      864           
=======================================
  Hits          597      597           
  Misses        267      267           
Flag Coverage Δ
unittests 69.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile.rules_generic Outdated Show resolved Hide resolved
@fbeutin-ledger fbeutin-ledger merged commit b82507e into master Aug 9, 2023
160 checks passed
@fbeutin-ledger fbeutin-ledger deleted the fbe/load_script_improvements branch August 9, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants