Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force enable seproxyhal in case of a debug build in the standard app … #414

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

apaillier-ledger
Copy link
Contributor

Description

Would prevent the compilation of debug builds of apps with DISABLE_SEPROXYHAL=1.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

…Makefile

Just like USB on devices other than the LNS
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (204c9b6) 69.37% compared to head (88b9a5f) 69.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage   69.37%   69.37%           
=======================================
  Files          11       11           
  Lines         875      875           
=======================================
  Hits          607      607           
  Misses        268      268           
Flag Coverage Δ
unittests 69.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apaillier-ledger apaillier-ledger merged commit 5b076fe into master Aug 31, 2023
160 checks passed
@apaillier-ledger apaillier-ledger deleted the fix/apa/debug_without_seproxyhal branch August 31, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants