Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib_nbgl: Constify nbgl_layoutTagValueList_t pairs element #460

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

xchapron-ledger
Copy link
Contributor

Description

lib_nbgl: Constify nbgl_layoutTagValueList_t pairs element
this allow to use const pairs, and therefore pairs from flash without having to drop the const qualifier.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4569539) 69.09% compared to head (4a02f17) 69.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #460   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files          11       11           
  Lines         877      877           
=======================================
  Hits          606      606           
  Misses        271      271           
Flag Coverage Δ
unittests 69.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xchapron-ledger xchapron-ledger merged commit 5893d08 into master Oct 31, 2023
160 checks passed
@xchapron-ledger xchapron-ledger deleted the xch/nbgl-constification branch October 31, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants