Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.rules_generic: Stop allowing app custom SCRIPT_LD #477

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

xchapron-ledger
Copy link
Contributor

Description

Makefile.rules_generic: Stop allowing app custom SCRIPT_LD

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3f06b3) 59.44% compared to head (1a42176) 59.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   59.44%   59.44%           
=======================================
  Files          12       12           
  Lines        1684     1684           
=======================================
  Hits         1001     1001           
  Misses        683      683           
Flag Coverage Δ
unittests 59.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xchapron-ledger xchapron-ledger merged commit 3786673 into master Dec 1, 2023
158 checks passed
@xchapron-ledger xchapron-ledger deleted the xch/drop-custom-linker-script branch December 1, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants