Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FWEO-1133 - APP SDK - Streamed transactions shouldn't have a back arrow navigation #633

Merged

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to fix https://ledgerhq.atlassian.net/browse/FWEO-1133 by a better analysis of when to draw the back navigation key.
Moreover, in transactions this back navigation key shall be placed at the same place, when we display the page number or not.

Changes include

  • [*] Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.85%. Comparing base (29e06e7) to head (8d80c12).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #633       +/-   ##
===========================================
+ Coverage        0   59.85%   +59.85%     
===========================================
  Files           0       12       +12     
  Lines           0     1684     +1684     
===========================================
+ Hits            0     1008     +1008     
- Misses          0      676      +676     
Flag Coverage Δ
unittests 59.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib_nbgl/include/nbgl_layout.h Outdated Show resolved Hide resolved
lib_nbgl/src/nbgl_layout_navigation.c Outdated Show resolved Hide resolved
lib_nbgl/src/nbgl_use_case.c Outdated Show resolved Hide resolved
@nroggeman-ledger nroggeman-ledger force-pushed the fix-fweo-1133-stream-trasaction-without-back-arrow branch from 8d80c12 to 241fd9e Compare April 23, 2024 12:02
@nroggeman-ledger nroggeman-ledger force-pushed the fix-fweo-1133-stream-trasaction-without-back-arrow branch from 241fd9e to 0b63cc8 Compare April 23, 2024 12:04
@nroggeman-ledger nroggeman-ledger merged commit 0e0db03 into master Apr 23, 2024
193 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fix-fweo-1133-stream-trasaction-without-back-arrow branch April 23, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants