Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep pointer for nbgl_layoutAddKeypad (LNX/LNS+) #634

Merged
merged 2 commits into from
May 2, 2024

Conversation

dmorais-ledger
Copy link
Contributor

@dmorais-ledger dmorais-ledger commented Apr 25, 2024

Description

This PR fix the issues introduced with the check_strings related PR:

  • it let the LNX/LNS+ version of nbgl_layoutAddKeypad use a pointer like before, and a string ID just when generating screenshots.
  • it limits to 4 lines per page on LNX/LNS+ devices only.

Changes include

  • Bugfix (non-breaking change that solves an issue)

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.89%. Comparing base (bb464fd) to head (c4ff171).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #634   +/-   ##
=======================================
  Coverage   59.89%   59.89%           
=======================================
  Files          12       12           
  Lines        1688     1688           
=======================================
  Hits         1011     1011           
  Misses        677      677           
Flag Coverage Δ
unittests 59.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib_nbgl/include/nbgl_layout.h Outdated Show resolved Hide resolved
lib_nbgl/src/nbgl_fonts.c Outdated Show resolved Hide resolved
@dmorais-ledger dmorais-ledger merged commit c69c301 into master May 2, 2024
194 checks passed
@dmorais-ledger dmorais-ledger deleted the use_ptr_no_id branch May 2, 2024 08:37
@lpascal-ledger lpascal-ledger mentioned this pull request May 16, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants