Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flex: Fix HTA double segment issue #635

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

abonnaudet-ledger
Copy link
Member

@abonnaudet-ledger abonnaudet-ledger commented Apr 26, 2024

https://ledgerhq.atlassian.net/browse/FWEO-1128

Description

When fast mode is enabled, first "hold to approve" segments were displayed almost at the same time. One at touch, the other on the next ticker event.
This commit remove the first segment that is displayed at touch.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.89%. Comparing base (a3b340f) to head (a34447f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #635   +/-   ##
=======================================
  Coverage   59.89%   59.89%           
=======================================
  Files          12       12           
  Lines        1688     1688           
=======================================
  Hits         1011     1011           
  Misses        677      677           
Flag Coverage Δ
unittests 59.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abonnaudet-ledger abonnaudet-ledger merged commit cc3dfd9 into master Apr 26, 2024
193 checks passed
@abonnaudet-ledger abonnaudet-ledger deleted the abo_fix_double_segments_hta branch April 26, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants