Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clean] Replace deprecated #defines with their replacements #666

Merged
merged 1 commit into from
May 17, 2024

Conversation

lpascal-ledger
Copy link
Contributor

Description

Some #define has been deprecated, but they are still used in the code, leading to compilation warnings (already on API_LEVEL_19).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (d9f6212) to head (4d099be).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #666   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files          12       12           
  Lines        1723     1723           
=======================================
  Hits         1042     1042           
  Misses        681      681           
Flag Coverage Δ
unittests 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpascal-ledger lpascal-ledger merged commit e21f13e into master May 17, 2024
193 checks passed
@lpascal-ledger lpascal-ledger deleted the lpa/update_deprecated_defines branch May 17, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants