Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aes cipher portability issue #668

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

jarevalo-ledger
Copy link
Contributor

Description

Use types that are arch-independent to avoid 32/64 bit portability issues.
Some unit-tests running on x86 64-bit with sanitizers enabled fails.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (e21f13e) to head (9899632).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #668   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files          12       12           
  Lines        1723     1723           
=======================================
  Hits         1042     1042           
  Misses        681      681           
Flag Coverage Δ
unittests 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jarevalo-ledger jarevalo-ledger merged commit 25f141f into master May 20, 2024
192 checks passed
@jarevalo-ledger jarevalo-ledger deleted the fix-aes-cipher-portability branch May 20, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants