Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bling warning indication for reviews, to warn user in some cases. #674

Merged
merged 1 commit into from
May 27, 2024

Conversation

nroggeman-ledger
Copy link
Contributor

@nroggeman-ledger nroggeman-ledger commented May 27, 2024

Description

The goal of this PR is to enable bling warning indication for reviews, to warn user in some cases.
A warning button is displayed on top-right of the first and last pages of the review, and when touched a modal warning text is displayed.
It can be activated by adding | BLIND OPERATION to operationType param of review.
It enables for example the modal screen presented in https://ledgerhq.atlassian.net/browse/B2CA-1667

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • [*] New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (4799a57) to head (aeb8718).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #674   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files          12       12           
  Lines        1723     1723           
=======================================
  Hits         1042     1042           
  Misses        681      681           
Flag Coverage Δ
unittests 60.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger force-pushed the enable-blind-warning-indication branch from 710826c to aeb8718 Compare May 27, 2024 08:53
@nroggeman-ledger nroggeman-ledger merged commit 95661ea into master May 27, 2024
193 checks passed
@nroggeman-ledger nroggeman-ledger deleted the enable-blind-warning-indication branch May 27, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants