Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick nbgl level21 #802

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

nroggeman-ledger
Copy link
Contributor

Description

Cherry-pick NBGL improvements from Master to API_LEVEL_21:

  • Create a QR Code type of modal window for Tag/Value alias
  • No "swipe to review" in first page of review if using a Tip-Box
  • Add extension to INFOS_LIST to enable alias for some info types

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.76%. Comparing base (603cf09) to head (92bebd2).
Report is 80 commits behind head on API_LEVEL_21.

Additional details and impacted files
@@                Coverage Diff                @@
##           API_LEVEL_21     #802       +/-   ##
=================================================
- Coverage         60.19%   35.76%   -24.44%     
=================================================
  Files                12       13        +1     
  Lines              1726     1591      -135     
=================================================
- Hits               1039      569      -470     
- Misses              687     1022      +335     
Flag Coverage Δ
unittests 35.76% <ø> (-24.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit dd7ebf5 into API_LEVEL_21 Oct 17, 2024
178 checks passed
@nroggeman-ledger nroggeman-ledger deleted the cherry-pick-nbgl-level21 branch October 17, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants