Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up arguments passed to the assembler - cherry-pick on API level 21 #806

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

apaillier-ledger
Copy link
Contributor

Description

#804

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Removes need for -Wno-unused-command-line-argument

(cherry picked from commit 639b629)
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.76%. Comparing base (603cf09) to head (8746085).
Report is 85 commits behind head on API_LEVEL_21.

Additional details and impacted files
@@                Coverage Diff                @@
##           API_LEVEL_21     #806       +/-   ##
=================================================
- Coverage         60.19%   35.76%   -24.44%     
=================================================
  Files                12       13        +1     
  Lines              1726     1591      -135     
=================================================
- Hits               1039      569      -470     
- Misses              687     1022      +335     
Flag Coverage Δ
unittests 35.76% <ø> (-24.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apaillier-ledger apaillier-ledger marked this pull request as ready for review October 17, 2024 09:23
@apaillier-ledger apaillier-ledger merged commit a350cec into API_LEVEL_21 Oct 17, 2024
178 checks passed
@apaillier-ledger apaillier-ledger deleted the cherry_pick_21 branch October 17, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants