1.11.1 changing fileSytem permissions to optional

LedgerHQ · Apr 17, 2018 · 8e963f1 · 8e963f1
1 parent 9e20715
commit 8e963f1
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,8 @@
 # Changelog
+1.11.1
+===
+- Changed the filesystem permissions to optional
+
 1.11.0
 ===
 - Removed wrongly displayed "hardware" menu in settings

diff --git a/app/manifest.yml b/app/manifest.yml
@@ -1,6 +1,6 @@
 name: "__MSG_application_name__"
 description: "__MSG_application_small_description__"
-version: "1.11.0"
+version: "1.11.1"
 manifest_version: 2
 minimum_chrome_version: "50"
 default_locale: "en"
@@ -23,10 +23,7 @@ permissions:
   - "notifications"
   - "usb"
   - "hid"
-  - fileSystem:
-    - "write"
-    - "retainEntries"
-    - "directory"
+  - "fileSystem"
   -
     usbDevices:
       -
@@ -56,6 +53,10 @@ permissions:
 
 optional_permissions:
   - "videoCapture"
+  -
+    fileSystem:
+      - "write"
+
 
 externally_connectable:
   ids:

diff --git a/app/src/utils/logger.coffee b/app/src/utils/logger.coffee
@@ -119,13 +119,16 @@ class @ledger.utils.Logger
       callback?(name: name, url: zip.url())
 
   @downloadLogsToZip: ->
-    @exportLogsToZip (data) ->
-      chrome.fileSystem.chooseEntry {"type": "saveFile", "suggestedName": data.name},
-        (file) =>
-          file.createWriter (writer) =>
-            writer.onwriteend = (e) =>
-              console.log("logs saved")
-            writer.write(data.zip)
+    ledger.managers.permissions.request {permissions: [
+      "fileSystem.write"
+    ]}, (granted) =>
+      @exportLogsToZip (data) ->
+        chrome.fileSystem.chooseEntry {"type": "saveFile", "suggestedName": data.name},
+          (file) =>
+            file.createWriter (writer) =>
+              writer.onwriteend = (e) =>
+                console.log("logs saved")
+              writer.write(data.zip)
 
   @downloadLogsWithLink: ->
     @exportLogsWithLink (data) ->