Merge pull request #189 from LedgerHQ/fbe/move_review_tap_on_stax

Move review.tap coordinates on Stax from center to center left to avoid clicking on QR code button

.github/workflows/build_and_tests.yml

@@ -51,7 +51,7 @@ jobs:
         pip install -U click>=8
 
     - name: Download app binaries
-      uses: actions/download-artifact@v3
+      uses: actions/download-artifact@v4
       with:
         name: boilerplate_binaries
         path: ./build/

.github/workflows/documentation.yml

@@ -34,7 +34,7 @@ jobs:
       - name: Generate the documentation
         run: (cd doc && make html)
       - name: Upload documentation bundle
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: documentation
           path: doc/build/html/
@@ -46,9 +46,9 @@ jobs:
     if: github.event_name == 'push'  && (github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/tags/'))
     steps:
       - name: Download documentation bundle
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
       - name: Deploy documentation on pages
-        uses: peaceiris/actions-gh-pages@v3
+        uses: peaceiris/actions-gh-pages@v4
         with:
           github_token: ${{ secrets.GITHUB_TOKEN }}
           publish_dir: documentation/

.gitignore

@@ -7,8 +7,7 @@ build/
 dist/
 __version__.py
 
-tests/elfs/
-snapshots-tmp/
+tests/snapshots-tmp/
 ledger_app.toml
 
 # doc

CHANGELOG.md

@@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.20.1] - 2024-06-19
+
+### Fixed
+- navigator: Moved review.tap coordinates on Stax from center to center left to avoid clicking on QR code button
+
 ## [1.20.0] - 2024-05-31
 
 ### Added

src/ragger/firmware/touch/positions.py

@@ -29,6 +29,7 @@ def __iter__(self):
 
 # Stax resolution is 400x670
 STAX_CENTER = Position(200, 335)
+STAX_CENTER_LEFT = Position(200, 40)
 # Flex resolution is 480x600
 FLEX_CENTER = Position(240, 300)
 
@@ -468,7 +469,7 @@ def __iter__(self):
     },
     "UseCaseReview": {
         Firmware.STAX: {
-            "tap": STAX_CENTER,
+            "tap": STAX_CENTER_LEFT,
             "previous": STAX_BUTTON_UPPER_LEFT,
             "confirm": STAX_BUTTON_ABOVE_LOWER_MIDDLE,
             "reject": STAX_BUTTON_LOWER_MIDDLE,