Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocr stax #408

Merged
merged 21 commits into from
Jul 31, 2023
Merged

Ocr stax #408

merged 21 commits into from
Jul 31, 2023

Conversation

dmorais-ledger
Copy link
Contributor

@dmorais-ledger dmorais-ledger commented Jul 7, 2023

This PR remove completely tesseract and add support for a fake OCR based on Bitmap Character Recognition.
It fully support API_LEVEL_5 (LNX & LNS+) as well as API_LEVEL_11 (stax) and API_LEVEL_12 (stax, LNX & LNS+) and will fallback on legacy fake OCR for other API levels.

Copy link
Contributor

@lpascal-ledger lpascal-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is red, some tests are whining!

speculos/mcu/ocr.py Show resolved Hide resolved
speculos/mcu/ocr.py Outdated Show resolved Hide resolved
speculos/mcu/ocr.py Outdated Show resolved Hide resolved
speculos/mcu/ocr.py Outdated Show resolved Hide resolved
speculos/mcu/ocr.py Outdated Show resolved Hide resolved
speculos/mcu/ocr.py Outdated Show resolved Hide resolved
speculos/mcu/ocr.py Outdated Show resolved Hide resolved
src/bolos/nbgl.c Outdated Show resolved Hide resolved
speculos/mcu/nbgl.py Outdated Show resolved Hide resolved
speculos/mcu/seproxyhal.py Outdated Show resolved Hide resolved
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering how the changes impact the API? E.g; when are text event decoded and notified?

speculos/fonts/stax-fonts-11.bin Outdated Show resolved Hide resolved
speculos/main.py Outdated Show resolved Hide resolved
@xchapron-ledger
Copy link
Contributor

CI is failing until we update ragger and boilerplate.

@dmorais-ledger dmorais-ledger merged commit 1c0b8f1 into master Jul 31, 2023
17 of 18 checks passed
@dmorais-ledger dmorais-ledger deleted the ocr_stax branch July 31, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants