Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when executing commands from signs #156

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Fix crash when executing commands from signs #156

merged 3 commits into from
Feb 10, 2024

Conversation

thecatcore
Copy link
Member

Closes #151

BluCobalt
BluCobalt approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@BluCobalt BluCobalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the other classes in that package, that have unresolved references? (iirc)

@thecatcore
Copy link
Member Author

It seems the only one not resolved at build time. So it should be good now.
I don't remember why I renamed it in a previous commit when I should not have done so.

@thecatcore thecatcore merged commit 6be689d into main Feb 10, 2024
2 checks passed
@thecatcore thecatcore deleted the fix-permissions-v1 branch February 10, 2024 21:27
@thecatcore thecatcore added this to the 1.9.2 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BluCobalt BluCobalt BluCobalt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Legacy Fabric API
Status: Done
Milestone
1.9.2
Development

Successfully merging this pull request may close these issues.

[1.8-1.9] The sign cannot run commands
2 participants
@thecatcore @BluCobalt