Add miscellaneous mappings #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the class_1015 and class_0_681 in net.minecraft.client instead? |
Yeah, forgot to update packages when I originally mapped them |
|
Can you update your branch with latest changes I made? It fixes workflow. I'll review your pr when it's done. |
|
Updated, looks like it needs maintainer approval before the workflow is run. |
|
Is this spell check fail normal? looks like most of the files flagged aren't relevant to this PR. |
|
Yes, ignore spellcheck for v2 branch, the config needs to be updated for it. |
thecatcore
approved these changes
Sep 5, 2024
thecatcore
requested changes
Sep 5, 2024
mappings/net/minecraft/predicate/block/BlockStatePredicate.mapping
Outdated
Show resolved
Hide resolved
Co-authored-by: Cat Core <[email protected]>
thecatcore
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of mappings based on 1.20.4 fabric (yarn mappings) for 1.8.9.