Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity related mappings #278

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Entity related mappings #278

merged 8 commits into from
Sep 26, 2024

Conversation

Sychic
Copy link

@Sychic Sychic commented Sep 21, 2024

Includes mapping most of living entity and entity classes. This includes parts of other classes which were referenced in those classes.

@thecatcore
Copy link
Member

thecatcore commented Sep 21, 2024

There is a conflict to fix:

METHODs net/minecraft/class_1297/[method_0_6892, method_5713]()Z -> checkWaterState

@thecatcore
Copy link
Member

There is a conflict in 1.10.x, make sure all interfaces and abstract classes declaring method_5797/getDisplayName have the same name for it. Sometimes when a method is declared in multiple places, an entry needs to be created for each one in mappings with the same name.

See for example getName() which is declared in both Entity abstract class and BossBarProvider interface in old mappings.

@thecatcore thecatcore merged commit 66b56c4 into Legacy-Fabric:v2 Sep 26, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants