Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/10_Sidebar_fix_readme #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feature/10_Sidebar_fix_readme #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions 10_Sidebar/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,12 @@ _./src/index.html_
+ <body id="main">
```

_./src/main.tsx_

```diff
+ document.getElementById('main')
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This main and the change above (<body id="main">) has no sense and should be removed from readme. It also was not implemented in code. Could you remove it please?

Apply the same change on ES readme 🙏

- Let's place the component adding it into the `app.tsx`:

_./src/app.tsx_
Expand Down
6 changes: 6 additions & 0 deletions 10_Sidebar/readme_es.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,12 @@ _./src/index.html_
+ <body id="main">
```

_./src/main.tsx_

```diff
+ document.getElementById('main')
```

- Situemos el componente añadiendolo dentro de `app.tsx`:

_./src/app.tsx_
Expand Down