-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating the formatting #34
Conversation
Reviewer's Guide by SourceryThis pull request updates the GitHub Actions workflow to create releases automatically, modifies the frame saving format in the video sampler, and adds new configuration options for the save format. The changes improve the CI/CD pipeline and enhance the flexibility of the video sampling process. Architecture diagram for updated GitHub Actions workflowgraph TD;
A[GitHub Actions] -->|Trigger on PR merge or workflow dispatch| B[Build Job];
B -->|Outputs version| C[Release Job];
C -->|Create release with version| D[GitHub Repository];
Updated class diagram for SamplerConfig and SaveFormatConfigclassDiagram
class SamplerConfig {
dict summary_config
int n_workers
SaveFormatConfig save_format
}
class SaveFormatConfig {
bool encode_time
bool include_filename
}
SamplerConfig --> SaveFormatConfig
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LemurPwned - I've reviewed your changes - here's some feedback:
Overall Comments:
- The new
format_output_path
method introduces additional complexity. Consider making the base64 encoding and filename inclusion optional or provide a clear rationale for their necessity. This will help maintain backwards compatibility and keep the default behavior simple. - Great job on improving the GitHub Actions workflow for automating releases. This will streamline the release process and improve consistency.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Enhance the video sampler by adding a method to format output paths with options for encoding time and including filenames. Update the GitHub Actions workflow to automate release creation by extracting the version from the project configuration. Improve the README formatting for clarity.
Enhancements:
CI:
Documentation: