send itp mail via npm2deb #148
Conversation
nileshpatra
force-pushed
the
automate_itp_mail
branch
from
16e4c1e
to
813f3d6
Compare
|
@guimard , did the changes as desired, using mail + editor.(seems to work on my machine) Could you please review? |
nileshpatra
force-pushed
the
automate_itp_mail
branch
2 times, most recently
from
f2969c9
to
544f31a
Compare
Seems good for me. However, I've no talents in Python. I let review for someone else |
Noted, Thanks a lot for guiding me, :) @shanavas786 @LeoIannacone could you please review the PR? |
npm2deb/scripts.py
Outdated
| @@ -147,6 +147,11 @@ def main(argv=None): | |||
| 'name', nargs='?', help='the license name to show') | |||
| parser_license.set_defaults(func=print_license) | |||
|
|
|||
| parser_senditpmail = subparsers.add_parser('senditpmail', help="send itp mail from template") | |||
| parser_senditpmail.add_argument( | |||
| 'file', help='pass file location toend mail from') | |||
|
@nileshpatra Thanks for your contribution
Does it invoke editor in your system ? |
No, you would need to modify the template (_itp.mail) on doing npm2deb senditpmail package-name_itp.mail, it should send the mail. |
nileshpatra
force-pushed
the
automate_itp_mail
branch
from
544f31a
to
b4b2312
Compare
|
well, then the subject should not contain 'FIX_ME', would be better to capture it from user. |
Solves #45