Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows build: fix narrowing error for WaitForSingleObject #1

Merged
merged 1 commit into from
May 23, 2022
Merged

Windows build: fix narrowing error for WaitForSingleObject #1

merged 1 commit into from
May 23, 2022

Conversation

Snider
Copy link
Member

@Snider Snider commented May 23, 2022

WaitForSingleObject returns a DWORD, not an int, so assign retval as such and it should fix the error.

Windows build: fix narrowing error for WaitForSingleObject
026dbc8 
`WaitForSingleObject` returns a `DWORD`, not an int, so assign `retval` as such and it should fix the error.
@Snider Snider requested a review from wrkzdev May 23, 2022 10:22
@Snider Snider merged commit 28d108c into LetheanMovement:master May 23, 2022
@Snider
Copy link
Member Author

Snider commented May 23, 2022

This should fix the broken build.

https://github.com/dAppServer/itw3/runs/6556213269

@jeffro256 jeffro256 deleted the win_narrowing_err branch May 23, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrkzdev wrkzdev Awaiting requested review from wrkzdev

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Snider