feat: lecture-5 HW #122
Open
feat: lecture-5 HW #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Letto228
reviewed
Aug 2, 2023
| @@ -21,5 +21,6 @@ import {PopupHostModule} from './components/popup-host/popup-host.module'; | |||
| PopupHostModule, | |||
| ], | |||
| bootstrap: [AppComponent], | |||
| exports: [], | |||
| @@ -26,4 +26,9 @@ export class ProductsListComponent implements OnInit { | |||
| // eslint-disable-next-line no-console | |||
| console.log(event); | |||
| } | |||
|
|
|||
| onLoad(event: unknown) { | |||
There was a problem hiding this comment.
Почему в типизации поставил unknown? Разве не известно, что будет приходить?
There was a problem hiding this comment.
Это была заглушка про которую я потом забыл, исправлю
| @@ -0,0 +1,4 @@ | |||
| export enum LoadDirection { | |||
| UP, | |||
There was a problem hiding this comment.
Лучше значениям enum давать говорящие имена, а не использовать дефолтные (0, 1, 2, ...)
Почему говорящие имена лучше? - если захотим добавить логирование или собирать метрики, то сделать это будет проще, т.к. будет отправляться не 0, 1 и т.д., а, например, before, after и т.д.
There was a problem hiding this comment.
Спасибо за совет, думаю так действительно лучше
| selector: '[appScrollWithLoading]', | ||
| }) | ||
| export class ScrollWithLoadingDirective { | ||
| @Output() loadData = new EventEmitter<LoadDirection>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.