Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always upload to production zenodo #94

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

sk1p
Copy link
Member

@sk1p sk1p commented Apr 17, 2024

This means we don't have to babysit the deposition and update the deposition ID if the sandbox is wiped etc...

The deposition is not published automatically, so it's still a good way of checking the metadata before publishing the full release.

Contributor Checklist:

The deposition is not published automatically, so it's still a good way
of checking the metadata before publishing the full release.
@sk1p sk1p added the enhancement New feature or request label Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.81%. Comparing base (4bd6b3b) to head (fb36e23).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #94   +/-   ##
=======================================
  Coverage   86.81%   86.81%           
=======================================
  Files          14       14           
  Lines        1191     1191           
  Branches      171      171           
=======================================
  Hits         1034     1034           
  Misses        105      105           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sk1p sk1p requested a review from uellue April 17, 2024 10:52
@sk1p sk1p mentioned this pull request Apr 17, 2024
4 tasks
@uellue
Copy link
Member

uellue commented Apr 17, 2024

Looks good, try merge & RC, I'd say. Easiest way to test :-)

@uellue uellue merged commit 27da50e into LiberTEM:master Apr 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants