Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Python 3.10+ union-style param in function tool #22

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

RezaRahemtola
Copy link
Member

What does this PR do?

Adds a test for the chat template generation issue fixed here: huggingface/transformers#35103

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or Telegram? Please add a link
    to it if that's the case.
  • Did you write any new necessary tests?

@RezaRahemtola RezaRahemtola self-assigned this Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (b4bf68a) to head (e3c8359).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   84.69%   84.69%           
=======================================
  Files          12       12           
  Lines         281      281           
=======================================
  Hits          238      238           
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RezaRahemtola RezaRahemtola force-pushed the reza/test-union-style-function-tool branch from 802ac70 to e3c8359 Compare January 17, 2025 07:32
@RezaRahemtola RezaRahemtola marked this pull request as ready for review January 17, 2025 07:33
@RezaRahemtola RezaRahemtola merged commit 56dd0b7 into main Jan 17, 2025
10 checks passed
@RezaRahemtola RezaRahemtola deleted the reza/test-union-style-function-tool branch January 17, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant