Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geomesh pts counted double #877

Closed
wants to merge 2 commits into from
Closed

geomesh pts counted double #877

wants to merge 2 commits into from

Conversation

fr-an-k
Copy link
Contributor

@fr-an-k fr-an-k commented Nov 26, 2023

GEOMESH pts are a pair of coordinates, but the count was incorrectly increased for each, i.e. counting double.
It caused an invalid DWG error without log message.
This fixes it.

@fr-an-k
Copy link
Contributor Author

fr-an-k commented Nov 26, 2023

Bug and testfile is described in #875 (this PR solves the bug but does not solve the original issue of the missing dxfread program)

@fr-an-k fr-an-k mentioned this pull request Nov 26, 2023
@fr-an-k fr-an-k closed this Nov 26, 2023
@rurban
Copy link
Contributor

rurban commented Nov 27, 2023

Why did you close it? dxfread is not needed, and the geomesh fix looks good. Just force push without the 2nd commit

@rurban rurban reopened this Nov 27, 2023
@rurban rurban closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants