WASM module and NPM library (javascript bindings) #892

fr-an-k · 2023-12-09T21:21:19Z

I made a simple LibreDWG file conversion library for easier interoperability.
I was hoping a WASM build of this could be released by default.
WASM (with 3 exports) is easy to fit onto any machine or language without manual compilation.
I will also make an NPM library wrapper around it.

I'm not finished, but I'm stuck on why autotools is seeing my new flag (in help and log) after running autogen.sh, but not picking it up when I set it, I tried many things but it seems I'm missing something trivial.

I was hoping someone could help out.
My commands with emscripten:

./autogen.sh
mkdir .build-wasm
(cd .build-wasm && emconfigure ../configure --enable-libconvert-only --disable-bindings --disable-shared)
(cd .build-wasm && emmake make -j)

In stdout it doesn't mention my flag, in .build-wasm/config.log it mentions it but says it's not detected, defaulting to "no".

My addition to configure.ac:

dnl --enable-libconvert-only
AC_MSG_CHECKING([for --enable-libconvert-only])
AC_ARG_ENABLE([libconvert-only],AS_HELP_STRING([--enable-libconvert-only],[
    Build only the library for pure file format conversion (default: no).]),
  [libconvert_only=yes
  AC_MSG_RESULT([yes])],
  AC_MSG_RESULT([no (default)]))
AM_CONDITIONAL([LIBCONVERTONLY], [test x$libconvert_only = xyes])

(The cmake route does not seem to work in any way, so I'll have to use autotools)

I was also wondering if it would be acceptable to put the NPM library under the usual ISC/MIT license within this repository. Bundled GPLv3 javascript does not require one to open up their source code, but it's scary for those who don't understand this, since Javascript only exists as source code. The actual LibreDWG library is in compiled form (WASM).

codecov · 2023-12-09T21:36:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10c79fd) 73.77% compared to head (16e8294) 73.77%.
Report is 7 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #892   +/-   ##
=======================================
  Coverage   73.77%   73.77%           
=======================================
  Files           2        2           
  Lines         122      122           
=======================================
  Hits           90       90           
  Misses         32       32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rurban · 2023-12-10T18:44:25Z

bindings/js/package.json

+  "version": "0.0.0-dev.0",
+  "description": "GNU LibreDWG is a free library to handle DWG/DXF files",
+  "main": "index.js",
+  "repository": "git://fr-an-k/libredwg.git",


it's just a test through my fork and reservation of the library name, of course I will transfer ownership if desired. I just need auto updates in my production environment.

It's not a valid Url mostly. The domain is missing

rurban · 2023-12-10T22:06:14Z

I don't like the libconvert-only flag, convert.c is wasm-only. Therefore it should be moved to bindings/js

fr-an-k · 2023-12-10T22:43:02Z

I'll try to make it a separate target instead of a flag, but I'm not sure if that can work.

It's not wasm only, it's very useful for anyone who just needs file conversion.
It does one single thing well, with common parameter types, the structs don't need to be ported, the binding itself doesn't need to change as formats are added.
It's the functionality that LibreDWG offers through CLI, so it makes sense to have it as a readymade module.

Later it could for instance be extended to add/remove/update individual JSON/DXF features quickly, as a string based version of LibreDWG. The normal LibreDWG API is not portable to higher languages by itself. The majority of programmers are currently not able to utilize LibreDWG at all.

It doesn't need maintenance and I believe it shouldn't be put in a separate repository.

WASM is also useful separate from javascript, for instance because it's sandboxed and therefore easy to accept in a strictly regulated enterprise.

I'm just combining it all in one PR to make them work together.

rurban · 2023-12-11T09:06:53Z

The size_t printf probe needs to be spezialized for emscripten also

rurban · 2023-12-11T09:14:50Z

I'll try to make it a separate target instead of a flag, but I'm not sure if that can work.

You just need to make the src/libredwg.lo, and the bindings/convert.lo and link them together. No need for a configure/cmake flag.

It's an abstraction of our programs binaries, useful for modules. But we cannot violate the namespaces this way (read/write without dwg_ prefixes), only with bindings.

It doesn't need maintenance and I believe it shouldn't be put in a separate repository.

Sure.

I'm just combining it all in one PR to make them work together.

Yes, please squash it.

rurban · 2023-12-16T15:18:13Z

No need to close. Just force push please

qwuip789 · 2025-01-03T06:32:00Z

emconfigure: error: './configure --disable-bindings --disable-shared' failed (returned 1)
make: make
make: *** No targets specified and no makefile found. Stop.
emmake: error: 'make' failed (returned 2)

qwuip789 · 2025-01-03T06:34:58Z

configure: error: cannot find a suitable modifier
emconfigure: error: './configure --enable-libconvert-only --disable-bindings --disable-shared' failed (returned 1)
make: make
make: *** No targets specified and no makefile found. Stop.
emmake: error: 'make' failed (returned 2)

qwuip789 · 2025-01-03T07:37:54Z

./common.h:367:5: error: 'HAVE_FUNC_ATTRIBUTE_ALIGNED' is not defined, evaluates to 0 [-Werror,-Wundef]
367 | #if HAVE_FUNC_ATTRIBUTE_ALIGNED
| ^
dwg.c:120:18: error: format specifies type 'unsigned int' but the argument has type 'size_t' (aka 'unsigned long') [-Werror,-Wformat]
118 | LOG_ERROR ("Could not read file (%" PRIuSIZE " out of %" PRIuSIZE
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
119 | "): %s\n",
| ~~~~~~~~~~
120 | size, dat->size, filename)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~

qwuip789 · 2025-01-03T08:57:54Z

libtool: error: '../src/libredwg.la' is not a valid libtool archive
make[2]: *** [Makefile:706: dwg2dxf] Error 1
make[2]: *** Waiting for unfinished jobs....
libtool: error: '../src/libredwg.la' is not a valid libtool archive
make[2]: *** [Makefile:726: dwgread] Error 1
libtool: error: '../src/libredwg.la' is not a valid libtool archive
make[2]: *** [Makefile:714: dwgbmp] Error 1
libtool: error: '../src/libredwg.la' is not a valid libtool archive
make[2]: *** [Makefile:722: dwglayers] Error 1
libtool: error: '../src/libredwg.la' is not a valid libtool archive
make[2]: *** [Makefile:702: dwg2SVG] Error 1
libtool: error: '../src/libredwg.la' is not a valid libtool archive
make[2]: *** [Makefile:730: dwgrewrite] Error 1
libtool: error: '../src/libredwg.la' is not a valid libtool archive
make[2]: *** [Makefile:734: dwgwrite] Error 1
libtool: error: '../src/libredwg.la' is not a valid libtool archive
make[2]: *** [Makefile:742: dxfwrite] Error 1
libtool: error: '../src/libredwg.la' is not a valid libtool archive
make[2]: *** [Makefile:738: dxf2dwg] Error 1
make[1]: *** [Makefile:709: all-recursive] Error 1
make: *** [Makefile:588: all] Error 2
emmake: error: 'make -j -s WARN_CFLAGS=-Wno-error' failed (returned 2)

fr-an-k added 7 commits December 8, 2023 08:19

npm, convert library and wasm action

f97acc3

npm, convert library and wasm action

11d928b

npm, convert library and wasm action

4cc7e64

manually test workflow

81e74cb

flag still not working

20fdec6

undo

4836dff

undo

16e8294

rurban reviewed Dec 10, 2023

View reviewed changes

rurban self-assigned this Dec 10, 2023

rurban added enhancement New feature or request cla_needed Waiting for the Copyright assignment labels Dec 10, 2023

fr-an-k closed this Dec 16, 2023

rurban reopened this Dec 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WASM module and NPM library (javascript bindings) #892

WASM module and NPM library (javascript bindings) #892

fr-an-k commented Dec 9, 2023 •

edited

Loading

codecov bot commented Dec 9, 2023 •

edited

Loading

rurban Dec 10, 2023

fr-an-k Dec 10, 2023

rurban Dec 10, 2023 •

edited

Loading

rurban commented Dec 10, 2023

fr-an-k commented Dec 10, 2023 •

edited by rurban

Loading

rurban commented Dec 11, 2023

rurban commented Dec 11, 2023

rurban commented Dec 16, 2023

qwuip789 commented Jan 3, 2025

qwuip789 commented Jan 3, 2025

qwuip789 commented Jan 3, 2025

qwuip789 commented Jan 3, 2025

WASM module and NPM library (javascript bindings) #892

Are you sure you want to change the base?

WASM module and NPM library (javascript bindings) #892

Conversation

fr-an-k commented Dec 9, 2023 • edited Loading

codecov bot commented Dec 9, 2023 • edited Loading

Codecov Report

rurban Dec 10, 2023

Choose a reason for hiding this comment

fr-an-k Dec 10, 2023

Choose a reason for hiding this comment

rurban Dec 10, 2023 • edited Loading

Choose a reason for hiding this comment

rurban commented Dec 10, 2023

fr-an-k commented Dec 10, 2023 • edited by rurban Loading

rurban commented Dec 11, 2023

rurban commented Dec 11, 2023

rurban commented Dec 16, 2023

qwuip789 commented Jan 3, 2025

qwuip789 commented Jan 3, 2025

qwuip789 commented Jan 3, 2025

qwuip789 commented Jan 3, 2025

fr-an-k commented Dec 9, 2023 •

edited

Loading

codecov bot commented Dec 9, 2023 •

edited

Loading

rurban Dec 10, 2023 •

edited

Loading

fr-an-k commented Dec 10, 2023 •

edited by rurban

Loading