Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Old Metric vitals Form #1629

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ahanipeitra1994
Copy link
Contributor

I have removed the "Disable Old Metric Vitals Form" issue #1626

@ahanipeitra1994 ahanipeitra1994 changed the title Diable Old Metric vitals Form Disable Old Metric vitals Form Jul 22, 2020
@maggienegm
Copy link
Contributor

LGTM

@ahanipeitra1994
Copy link
Contributor Author

ok i will work on that

@@ -181,8 +181,6 @@
{
// added 8-2009 by BM - do not show the metric vitals form as option since deprecated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the comments related to this code as well then it will be ready for merge.

@@ -179,8 +179,6 @@

foreach ( $inDir as $fname )
{
// added 8-2009 by BM - do not show the metric vitals form as option since deprecated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great.

@Ngai-E
Copy link
Collaborator

Ngai-E commented Aug 16, 2020

@maggienegm @muarachmann Is this okay now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants