Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSRF Fixes and Remote Code Execution Prevention #1634

Merged
merged 10 commits into from
Jul 19, 2021
Merged

CSRF Fixes and Remote Code Execution Prevention #1634

merged 10 commits into from
Jul 19, 2021

Conversation

maggienegm
Copy link
Contributor

@maggienegm maggienegm commented Aug 1, 2020 •
edited
Loading

This fix removes CSRF vulnerabilities and also prevents remote code execution attempts.

@Ngai-E Ngai-E mentioned this pull request Aug 2, 2020
Open
@maggienegm
Copy link
Contributor Author

Its necessary to type cast the inputs before supplying to hash_hmac, interesting things might occur if that is not done ( type juggling vulnerability ), if $secondToken is a user controlled input, if an array is passed, hash_hmac will return null.
For more details:
https://www.youtube.com/watch?v=MpeaSNERwQA

Added type casting to hash_hmac()'s input per @naveen17797 's comment in PR #1625

@maggienegm maggienegm changed the title Prevent csrf in vulnerable files with forms CSRF Fixes and Remote Code Execution Prevention Aug 8, 2020
@muarachmann muarachmann merged commit ec27daa into LibreHealthIO:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maggienegm @muarachmann @Ngai-E