Improved service management #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #1124.
The services now get started with Django and there is a cron job, which checks if the service is still running.
There are now a bunch of new endpoints:
[GET] /services/: List all services
[GET] /services/<service_name>/: Retrieve the health status of a service
[POST] /services/<service_name>/start/: Start a service
[POST] /services/<service_name>/stop/: Stop a service
Current limitations:
All stopped jobs, would start again on the reboot of the container as they are currently not persisted.
Maybe the implementation is a bit naive, I just start the process as sub processes and the keep in them in a list, if I want to terminate them.
Needs to be merged with: LibrePhotos/librephotos-docker#122