-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build_{rust,dpkg}.sh - scripts rework fixes/simplifications #505
base: develop
Are you sure you want to change the base?
Conversation
2b068bd
to
5e22b08
Compare
Tagging this for beta 2. I'll try and get it merged locally and tested today. I generally prefer keeping build scripts an obvious "one step at a time", so I may break some things out again for clarity (the build script is something you run pretty infrequently if you aren't actively working on the back-end, so it's a pretty low priority) |
For me lqos is mostly backend. I logged into GUI few times only. This means that its doing its work like a charm :) |
ok - now I see nothing to improve/clean, waiting for review+squash&merge, |
@thebracket did You checked this PR? It would be awesome if we could have this in beta2 |
@thebracket could we merging this now? it takes much minutes to resolve conflicts... |
@thebracket when will You do review? This is resolving few problems whitch users were asking on chat in last week. |
@thebracket what about merging this and bugfix #550 and release new beta? This is the state - I tested much on prod with very heavy load. |
@rchac maybe its time to merge also this? |
? |
@rchac @thebracket what about that PR? |
Some small improvements/bugfixes:
./bash -x build_rust.sh
or./bash -x build_dpkg.sh
(doubled files, bad compare operator for strings)