Skip to content
This repository was archived by the owner on Oct 21, 2022. It is now read-only.

Make vim-plugin compatible with close-brackets behaviors. #65

Merged
merged 2 commits into from
Jan 31, 2016

Conversation

TeachMeFly
Copy link
Contributor

See this discussion for more info.

@kenny-evitt
Copy link

@TeachMeFly Is this still needed?

Was this intended to fix the behavior where, even if the auto-close-brackets was disabled, the Vim plugin was still inserting closing brackets?

@TeachMeFly
Copy link
Contributor Author

@kenny-evitt yes, thats it.

@TeachMeFly
Copy link
Contributor Author

@kenny-evitt, this issue appears when autoclose-brackets is enabled.

@kenny-evitt
Copy link

@TeachMeFly I'm confused. If auto-close-brackets is enabled why should the Vim plugin prevent a closing bracket from being inserted when an user enters an open bracket?

@TeachMeFly
Copy link
Contributor Author

@kenny-evitt, it happends in vimMode, when you just open new tab and put cursor to some line . Pressing ']' and '[' must cause jump to mark before, but it insert '[]' brackets to code. If you enter insert mode and return back to vim mode, this bug disapear, and keys work as it should be.

@kenny-evitt
Copy link

@TeachMeFly Ahh; this happens in the Vim command mode. I'll check that. Would you add some very specific steps to reproduce this to the original issue so others can try to reproduce it too?

@cldwalker
Copy link
Member

Confirmed this is an issue on .js and .cljs files and will merge + release shortly. This is a reasonable temporary fix. Once #45 lands we won't need this fix. See codemirror/codemirror5#2061

@cldwalker
Copy link
Member

@TeachMeFly Thanks!

@cldwalker cldwalker merged commit 07474b7 into LightTable:master Jan 31, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants